Use safe_unpackstr_xmalloc() instead of unpackstr_ptr to ensure all
strings are escaped correctly in SlurmDBD.

This requires the introduction of the _free_local_*() functions to free
the structure members, whereas they were previously just pointers into
the single managed buffer which was cleaned up elsewhere.

Remove the unsafe unpackstr_ptr macro definition as well while here.

CVE-2019-12838.

Flags are stored in a smallint, which can only hold the first 16 bits
worth out of 32 bits of flags currently in use.

MySQL's overflow rules will treat any value > 0xffff as 0xffff, rather than
dropping the higher-order bits (flags), which means the stored value not
only loses the higher-order bits but corrupts the lower-order as well.

The 19.05 release extends the column to bigint (64 bit).

Bug 6969.

For heterogeneous jobs, do not count the each component against the QOS or
association job limit multiple times.

bug 7190

Bug 6847

Catch jobs with empty pack_job_id_sets.
Corruption bug fixed by previous commit.

Bug 6847

Rejected hetjobs were not correctly dump because pack_job_id_set was
not properly set in _slurm_rpc_allocate_pack() when submision was
rejected.

New helper function _create_pack_job_id_set() to avoid duplicated
code.

Bug 6847

Fix for test 21.39. If the job didn't start running before the
account/qos was removed, then the job would never start running, and the
test would fail.

Bug 6942.

Previous logic could hang indefinitely if srun did not return
It also performed unneeded test setup before confirming that the
system size was adequate to execute the test.

bug 7050

Remove excess tabs to properly align code
Make comment formats consistent

No functional changes.

Bug 7050.

Bug 7050.

Bug 7050.

Handles cases where last line of slurm.conf is not empty.

Bug 7050.

One part of this test can fail in a heterogeneous system. Do not run the
part of the test that would fail if the system is heterogeneous.

Bug 7051.

backport test7.20 changes from master to v18.08.

bug 7050

select/cons_res is recommended.

Bug 7138

Bug 6987.

Bug 6466.

Bug 7101.

The name variable hasn't been set yet, so this is always NULL. Print the
uid/gid instead. While here, treat uid/gid as uint32_t, and use strtoul()
rather than atoi() to avoid issues with high-number uid/gid values.

Fixes GCC 9 warning.

Bug 7101.

Bug 7101.

Use RETRY_DELAY per to mirror job complete delay but without a max retry
count for the time being.

Bug 6970.

Signed-off-by: Brian Christiansen <brian@schedmd.com>

Bug 6964

The reason was being set after the message was sent to the db. Also
clear the draing and reboot states before the message is sent so that
the event state will show DOWN.

Bug 6964

Bug 6964

so that new jobs can't get on the node.

Bug 6964

for completing job.

Bug 6927

Bug 6980

Bug 6945

Bug 6926

Continuation of 89b791bf.

Bug 7045.

To indicate that a job is dependent or has an invalid dependency.
Not used for now, just added and removed according to its meaning.

Bug 7045.

Bug 7080

Bug 7092.

Can happen if SrunPortRange has been set too small, especially on shared
login nodes launching multiple large-scale srun processes.

Bug 6916

Bug 6995

Job steps that run on cloud nodes and use the alias_list - in other
words, SlurmctldParameters=cloud_dns is not in slurm.conf - all talk
directly back to the slurmctld. To make that happen, we set the parent
tank of each stepd to -1. However, we also set the rank of each stepd to
0. this meant that when each stepd sent a REQUEST_STEP_COMPLETE RPC to
the slurmctld, they would tell slurmctld to clean up node 0 in the step
allocation. So, multi-node step allocations weren't cleaning up after
the steps completed and would cause subsequent job steps to hang. The
step allocations would only clean up properly at the end of the job.

Ensure that each stepd uses the correct rank so that job steps are
properly cleaned up after each step completes.

Bug 6467.