1. 27 Oct, 2016 3 commits
  2. 26 Oct, 2016 7 commits
  3. 25 Oct, 2016 4 commits
  4. 24 Oct, 2016 2 commits
    • Jacek Budzowski's avatar
      Fix for sstat on multi-node batch jobs · 8589ff40
      Jacek Budzowski authored
      There is a problem with gathering batch step statistics for jobs which are allocated on more than one node.
      
      Sstat asks wrong node for batch step stats. It requests info from last node from hostlist while it should ask first host from hostlist (i.e. BatchHost), because only on the first node the batch step actually executes.
      
      For example, when you have a job allocated on nodes n000[1-2] with BatchHost=p0001. You should be able to check its statistics by running sstat [ with -vv switch for more verbose output] (e.g. sstat -j 1234.batch -vv). Then you can see lines:
      
      sstat: debug:  slurm_job_step_stat: getting pid information of job 1234.4294967294 on nodes n0002
      sstat: debug:  job step 1234.4294967294 has already completed
      
      The problem lays in sstat source code. For batch step a hostlist variable is taken from the hostlist_pop function, which returns last host from given hostlist. This should be replaced with the hostlist_shift function, which returns first host from the given hostlist. Patch attached.
      
      bug 2975
      8589ff40
    • Dorian Krause's avatar
      Fux use-after-free in srun · 2c7c5459
      Dorian Krause authored
      This commit fixes a bug in the multi-prog handling. When running
      salloc -N 2 srun -O --multi-prog mp.conf where mp.conf reads
      
      0-192 true
      
      srun crashes can be observed. valgrind reports:
      
      ==6857== Invalid read of size 4
      ==6857==    at 0x45938D: bit_realloc (bitstring.c:189)
      ==6857==    by 0x5977A9: _update_task_mask (multi_prog.c:335)
      ==6857==    by 0x597A5E: _validate_ranks (multi_prog.c:403)
      ==6857==    by 0x597D1E: verify_multi_name (multi_prog.c:469)
      ==6857==    by 0x6E7B4BE: launch_p_handle_multi_prog_verify (launch_slurm.c:453)
      ==6857==    by 0x58A25D: launch_g_handle_multi_prog_verify (launch.c:493)
      ==6857==    by 0x58E556: _opt_args (opt.c:1927)
      ==6857==    by 0x58A3B9: initialize_and_process_args (opt.c:270)
      ==6857==    by 0x591F82: init_srun (srun_job.c:459)
      ==6857==    by 0x427E70: srun (srun.c:193)
      ==6857==    by 0x428E23: main (srun.wrapper.c:17)
      ==6857==  Address 0x5ace440 is 16 bytes inside a block of size 28 free'd
      ==6857==    at 0x4C2BB4A: realloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
      ==6857==    by 0x446886: slurm_xrealloc (xmalloc.c:139)
      ==6857==    by 0x45944C: bit_realloc (bitstring.c:191)
      ==6857==    by 0x5977A9: _update_task_mask (multi_prog.c:335)
      ==6857==    by 0x597A5E: _validate_ranks (multi_prog.c:403)
      ==6857==    by 0x597D1E: verify_multi_name (multi_prog.c:469)
      ==6857==    by 0x6E7B4BE: launch_p_handle_multi_prog_verify (launch_slurm.c:453)
      ==6857==    by 0x58A25D: launch_g_handle_multi_prog_verify (launch.c:493)
      ==6857==    by 0x58E556: _opt_args (opt.c:1927)
      ==6857==    by 0x58A3B9: initialize_and_process_args (opt.c:270)
      ==6857==    by 0x591F82: init_srun (srun_job.c:459)
      ==6857==    by 0x427E70: srun (srun.c:193)
      2c7c5459
  5. 20 Oct, 2016 4 commits
  6. 19 Oct, 2016 1 commit
  7. 18 Oct, 2016 2 commits
  8. 17 Oct, 2016 4 commits
  9. 15 Oct, 2016 1 commit
  10. 14 Oct, 2016 4 commits
  11. 13 Oct, 2016 8 commits