RPCs will switch to using bit_str_hex for serialization from bit_fmt,
but receivers still need to access this as a inx formatted array for now.
Collapse this into one macro rather than repeating a bunch of times.

Note that this would be better performing if consolidated into a single
function rather than using unpack_bit_str_hex then bitstr2inx to convert;
although this is a client-side function and less important than avoiding
performance and throughput issues within slurmctld.

pack_bit_fmt can exceed 0xfffe characters on large systems and thus
truncate leading to:
"error: Credential signature check: Credential data size mismatch"

Add warning to the pack_bit_fmt macro to highlight issue.

Bug 3257.

bug 3072

bug 3072

scancel modified to note that no jobs satisfy the filter options when the
    --verbose option is used along with one or more job filters (e.g. "--qos=").
bug 3072

scancel would treat a non-numeric argument as the name of jobs to be
    cancelled (a non-documented feature). Cancelling jobs by name now require
    the "--jobname=" command line argument.
bug 3072

Coverity was reporting possibly unterminated string

Bug 3395

Replace version borrowed from Linux 2.4.9 with newer version in 4.9.

burst_buffer/cray - Avoid "pre_run" operation if not using buffer (i.e.
    just creating or deleting a persistent burst buffer).
bug 3391

Previous job state information was "PENDING" rather than "REQUEUED"
  for each job requeued due to a burst buffer error.
bug 3388

of before where we could return before we actually used it.

xfree is probably fine in this instance.

scheduling a Datawarp job.

The assoc_mgr lock needs to happen before the bb_state.bb_mutex.  One place
this could cause deadlock is from src/slurmctld/controller.c
_accounting_cluster_ready() which calls clusteracct_storage_g_cluster_tres
which inturn calls bb_g_job_set_tres_cnt which calls bb_p_job_set_tres_cnt
which will lock the bb_muxtex after the assoc_mgr is already locked.

Bug 3389

bluegene system.

Bug 3331

and erroneous error later on.

Cache results of bit_set_count() calls.

Bug 3393.

The old logic would result in test16.4 failing some of the time.
  The failure was caused by the sattach command attaching to a
  job step before the original srun command received a
  RESPONSE_LAUNCH_TASKS message. That messsage  would then be sent
  to the salloc command. Since srun never got the message, it
  would hang. This change does not mark the job step as RUNNING
  until after the original srun gets sent the RESPONSE_LAUNCH_TASKS
  message and sattach requests are blocked until that time.

Identify the function where an error is generated.

This bug was introduced in commit 155a65a4
  A bad array index value was used.

This isn't a new bug, but logic in this area changed and Coverity
  reported it as a new problem (duplicate logic). The logic also
  incorrectly used a strstr() rather than strcmp() to find maching
  process names.