Previous implementation is not thread-safe.

Replace with direct references to the struct.

Improve backfill scheduling algorithm with respect to starting jobs as soon
    as possible while avoiding advanced reservations.
bug 3757

bug 3886

Not necessarily fatal(), but of potential interest when debugging
odd slurmctld crashes. Cannot go where the limit is originally set,
as the logging infrastructure is not avaiable at that point.

Bug 3886.

test1.91 fails with non-default binding

Bug 3581.

Fix for commit 250378c2
  test7.3 was failing without this patch
  bug 3502

test 17.12 was leaving slurm-#.out files around. Explicitly set
  output file to /dev/null and set time limit to 1 minute to avoid
  vestigial jobs.

Handle syncing between siblings (not the origin). Job could have been
canclled or started while the origin was down. The sibling should see
this and remove it's copy if the job is running or cancelled on the
remote cluster.

Handle case where job was cancelled or finished while the origin was
down and the siblings were up.

The controller will keeps job in the job_list until the origin comes
back up and will find out about it then.

This allows the origin to be able to sync up jobs after it has been
down.

(void *)(intptr_t)0 is treated as a NULL

_cleanup_removed_origin_jobs() could have been called without ever being
part of a federation.

Job could have been requeued if the nodes failed.

bef69448 was fixed/changed so that slurm_addto_char_list() would now
add an empty string to the list if no constraints or clusters were
given. The code was expecting an empty List previously.

Like sview it wasn't mapping the job's node indexes to the correct
nodes since federated nodes are merged into one array.