JobHeldUser state reason was properly set for user held jobs during the
course of job_allocate() execution until calling _select_nodes_parts()
which could override it under certain conditions (i.e. when accounting
policy limit is hit). The fix restores it back when appropriate.

Continuation of 8712a254.

Bug 7136.

Bug 7146.

No functional changes to fsync_and_close(), but tag the file_type as
const and clean up some minor style issues while moving this.

Add include for fd.h header where needed as well.

Bug 7146.

This streamlines the code a bit and uses more common code.

Parsing logic failed to support underscore in plugin names, which
is now the standard for "cray_aries" configurations.

Improve some descriptions of sdiag output and re-order some
descriptions to match current format.

Bug 7148.

One issue is that batch steps are listed in squeue -s output now.

Bug 6912.

The sacct command in verison 19.05 when job ID is specified will
find all examples of that job ID run at any time. That means if
the job IDs numbers wrap around, this test will always fail. This
adds a start time to the sacct command of 00:00 (midnight of current
day) to avoid problems with wrapping job IDs and make this test
work more like it did in version 18.08. Note this test does have
a very tiny window for failures if the test program ran just before
midnight and the sacct command to view it's state ran just after
midnight. Given that the entire test only runs for a minute, that
is unlikely in practice.

The fix for bug 7066 will break the original version of this test

bug 7066

Update NEWS, slurm.spec, and slurm.spec-legacy as well.

to match the other log messages that already print signal numbers.

Bug 6938.

This change avoid some operations on a node's GRES data
structure if the count of available GRES is zero.

bug 6997

The NULL size bitmap should be fixed in previous commit,
but this is an added check for improved code stability
in case something else goes wrong.

bug 6997

Previously with a configuration including FastSchedule=1 or 2,
GRES with files defined in gres.conf, and in the node configuration
either specified with a count of 0 or not included at all then
the node's GRES data would be built with a topology array containing
a GRES bitmap of zero size, resulting in an abort when trying to
operate on that bitmap.

bug 6997

Bug 6997

Bug 6987.

Commit: 03165950

Bug 6466.

Bug 6466.

Bug 7101.

The name variable hasn't been set yet, so this is always NULL. Print the
uid/gid instead. While here, treat uid/gid as uint32_t, and use strtoul()
rather than atoi() to avoid issues with high-number uid/gid values.

Fixes GCC 9 warning.

Bug 7101.

Bug 7101.

slurm_persist_send_msg() does not generally set errno on return.

Bug 7117.

Bug 7096

Bug 7113

Coverity CID 198461

Bug 7112

Coverity CID 198464

Since the struct has an array, Clang complains about the use
of {0}. We decided to replace that with memset.

Bug 7096

Bug 6783

Co-authored-by: Alejandro Sanchez <alex@schedmd.com>

Bug 7078.

For testing purposes, disabling PrologFlags=Alloc seems reasonable.
If/when we actually need to support front-end systems in the future,
the underlying code will likely have changed and require additional
changes.

Bug 7057.

This reverts commit 123cb8e2.

The reason this code doesn't work is there are other flags set on the
job_state that make it not just Pending.

See test28.2.  It has the JOB_UPDATE_DB flag set.