Modify test to work on cray/kachina system when allocated KNL node.

Test broke on cray/kachina when allocated KNL

Bug 6822

Bug 7061

Bug 7061

Bug 7061

Co-authored-by: Morris Jette <jette@schedmd.com>

Error reported by CLANG

Cherry pick to 18.08.

Bug 6996.

Jobs with zero nodes/CPUs are permitted to create and destroy
persistent burst buffers.

Bug 7034.

Bug 7034.

unlimited could get overwritten with default queue depth preventing the
whole queue from being looked at -- especially in a high-throughput
envrionment.

Bug 6822

Co-authored-by: Morris Jette <jette@schedmd.com>

Bug 5562

Bug 5562

Bug 5562

Node memory overallocation wouldn't be properly detected since we would
just be interpreting the available memory as RealMemory - MemSpecLimit,
ignoring other job's memory usage.

Bug 5562.

This compares a job memory request against each selected node available
memory, interpreting the latter for now as RealMemory - MemSpecLimit.

Bug 5562.

Place all three memory cases (per cpu, per node and all node memory) in
a single loop, since all three cases need to traverse all job_resources
selected nodes. Preparation for a follow-up commit that contains the
real fix.

Bug 5562.

Move common (or similar) logic to globals and remove it from
the individual tests.

Add handling for acct_gather_energy/xcc and acct_gather_profile/influxdb.

Bug 6829.

Bug 5773.

No functional change.

Bug 6508

Bug 6508

Previously when no memory was explicitly requested the job was assigned
the DefMemPer[CPU|Node] from the first partition in the list (or the
cluster-wide value if the partition wasn't configured with it), even
when evaluating against a different partition.

Bug 6950.

No functional change

Bug 5303

Bug 7072

Bug 6845

Log the ID of individual sub-tests in order to more easily identify
which sub-test failed rather than having to scan and compare the
various execute lines in the tests.

A batch job will run on front-end node, not an assigned compute node

The sacct command in verison 19.05 when job ID is specified will
find all examples of that job ID run at any time. That means if
the job IDs numbers wrap around, this test will always fail. This
adds a start time to the sacct command of 00:00 (midnight of current
day) to avoid problems with wrapping job IDs and make this test
work more like it did in version 18.08. Note this test does have
a very tiny window for failures if the test program ran just before
midnight and the sacct command to view it's state ran just after
midnight. Given that the entire test only runs for a minute, that
is unlikely in practice.

Change "Could not for..." to "Could not find ..."

Do not effect non-test jobs with the test LUA script to avoid
impacting jobs outside of this specific test.

Bug 7050

Bug 7050.

Previous logic only checked the first gpu record found, which
is not going to reliably work if the first gpu type is on one
socket and the next gpu type is on a different socket or itself
spans sockets.

The wrong variable was clearly being used resulting in a node's
"gres" string not containing the proper socket identification for
GRES bound to sockets.