A 17.02 controller,sacctmgr couldn't talk to a "master/17.11" DBD
because the 17.02 client was talking attempting to talk to the DBD with
the 17.02's MIN_PROTOCOL_VERSION -- which was 15.08 and is more than 2
version behind the master. The master's MIN_PROTOCOL_VERSION is 16.05,
so it couldn't unpack the messages.

The controller should always communicate at it's current protocol to the
DBD.

For federations, it's possible that a higher version controller could
talk to a lower version controller. So the cluster needs to talk to the
remote cluster using the remote cluster's protocol version -- which is
given back from the DBD.

No functional change.

Enable through SchedulerParameters. Will sort by youngest jobs first,
rather than based on priority. Use alongside 'preempt_strict_order' if
you don't want the plugin to try to further optimize the preemption
list.

Bug 3457.

Collapse begin_job_resv_check and fini_job_resv_check into
job_resv_check, and call directly from controller.c rather than
including in job_time_limit.

Introduced by commit 059275f6 when the timer is trigger.
Releasing the locks means that job_ptr may point to an element that was
deleted by a different thread in the meantime. Restructuring the code
to advance the iterator prevents this - the iterator itself does not have
this issue as the List structure will manage the position during the
sleep().

While here, move the reservation update handling outside of this
loop to simplify operation. This does not need to piggy-back on the
scan of the job_list - switching to using list_for_each should
mitigate some of the performance loss by needing a second full pass.

Bug 3414.

These were mis-calculated previously, and are internal implementation details
that weren't meant to be exposed.

association GrpWall limit.

limits.

Bug 3476

Bug 3476

old ones.

This is cosmetic only, no code change.

Bug 3476

Checked for suffix of "k" and "k" (not "K").
Same problem with suffic of "m".

Missed a sanity check.

to have a buffer to fill in.

Bug 3472

regcomp() is not safe to use across a fork in older glibc versions.
Reinitialize the keyvalue_re structure after the fork through an atfork()
handler.

Bug 3276.

This is a regression from commit b818dd9d

Basically the first AC_LINK_IFELSE sets whatever compiler we
are using to be that.  Since the above commit removed the BGL/P
code that was linked using C C++ became the compiler since the
next thing was BGQ in configure.ac to test against.

I just grabbed the DATABASES call, but any other one could had
worked.

another one.

Bug 3465

This is the way it is done with the task plugins.  It appears this only
really matters when requesting 1 task with a full socket with exclusive
access.  This code would cyclically allocate sockets to the step instead
of filling up one socket then going to the next.

Fix for job constraint specification with counts, --ntasks-per-node value,
    and no node count.
bug 3470

With the _DEBUG flag set a typecast was needed in a print statement
  for clean build

Task/cray: Treat missing "mems" cgroup with "debug" messages rather than
    "error" messages. The file may be missing at step termination due to a
    change in how cgroups are released at job/step end.

Honor --ntasks-per-node and --ntasks option when used with job constraints
    that contain node counts.
bug 3458