wait to retry or not.

I discovered this bug regression testing. Some similar situations will
result in srun continuously issuing step create requests and the
launch_common_create_job_step() function not sleeping between RPCs.
Basically launch_common_create_job_step() sleeps for some error codes
and srun retries the step create on some error codes. The problem is
that those error codes do not match in both places, resulting in
constant retries without sleeps. This situation is very likely with
job preemption combined with salloc, but other conditions can trigger
the same event. The following errno will all trigger this situation:
EAGAIN, ESLURM_DISABLED, ESLURM_POWER_NOT_AVAIL, ESLURM_POWER_RESERVED,
ESLURM_PROLOG_RUNNING, ESLURM_INTERCONNECT_BUSY.

Bug 4786

Bug 4772

Was checking time ranges against a bad cast'ed variable.
And MaxQueryTimeRange was being stored as minutes and was being compared
against the difference of two time_t's -- which produces seconds.

Bug 4772

was matching more than expected.

Bug 4789

Fixes issue with bf_min_prio_reserve not being respected, leading
to significantly impacted backfill performance.

Bug 4760.

Log that support for the ChosLoc configuration parameter will end in
Slurm version 18.08.

Bug 4791

And would prevent transmission of a file.

Bug 4787.

Bug 4736
Bug 4784

Partial write can happen under high system load, leading to step
termination when finishing the write would let the step launch
properly instead.

Fix suggested by Matthieu Hautreux.

Bug 4778.

Add a privilege check for when an unprivileged user tries to modify
a resource. Min level set to Operator.

Bug 4735.

Bug 4747.

Default --list_reasons format is "%20E %9u %19H %N"

Bug 4762

Fixes some issues around differences in lua package naming.

Bug 4568.

Reformat comment blocks to respect 80-columns
and /* comment */ format conventions.

Bug 4681.

Bug 4709.

Bug 4646

Report all SPANK validations that fail, not just the first one
Log local and remote plugstack.conf file checksum to identify
  possible file system delay issues
bug 4694

Previously it was taking the MIN, without respecting the order.

Also add a note to the resource_limits.html page to clarify the
exception for Max[Wall|Time] and/or [Max|Min]Nodes limits, where
the default is that the Partition is the king with regards of
precedence, unless the respective job's QOS flags
Partition[Min|Max|Time]Limit are set.

Bug 4681.

This prevents a hard-to-diagnose issue where slurmstepd may fail
to start due to a missing library. This now ensures slurmd will
fail, and keep the node down until the library issue can be fixed.

Bug 4645, 4644.

fatal() calls exit(1) which precludes getting a backtrace.
That's fine on configuration issues and other types of problem,
but for hitting "impossible" edge cases getting a core dump may
be the only way to isolate the issue.

Adding to 17.11 so we can easily provide diagnostic patches without
needing users to back-port this implementation. Further use will
come in 18.08.

Bug 4599.

This reverts commit 18b35709.

This reverts commit 26d2a4b5.

This reverts commit 6a91845b.

This reverts commit 50b49b0e.

Update slurm.spec and slurm.spec-legacy as well

Update slurm.spec and slurm.spec-legacy as well

CID 182713

Wait for the prolog to complete, and then clean up after it.
Otherwise orphaned "sleep" executables will be created by the
still-launching step_extern.

Bug 4718.