Bug 5672

Coverity CID 164845

Bug 5529

Seconded by Moe.

LaunchParameters=send_gids.

Bug 5620

Bug 5659

This reverts commit 35285e40.

Bug 5659

Bug 5663

Spaces need to be built into each key definition, otherwise it'll
all run together.

Bug 5657.

Otherwise assoc_mgr_fill_in_user() will abort on a failed lock annotation.

Convert to designated initializer format while fixing this.

Bug 5653.

Further work will be needed to track these independently.

Bug 5256.

Move the trigger_backup_ctld_fail() call into ping_controllers(),
and use the ping_all boolean as a standin for whether we're the active
controller or not.

Bug 5256.

The handling for response_time was a bit odd, as care was needed to make
the timestamp values match up. Meaning they're not really time values,
just a complicated way of signaling whether the remote controller is
responding. So, simplify this by just indicating through a bool whether
a given controller is responding or not.

Bug 5256.

If true, ping everyone except outselves. If false, continue to ping
only the higher priority controllers.

Also move the ctld_ping xmalloc and xfree in here so we don't need
to recreate them in the controller code later.

Bug 5256.

Both the primary and backup need to provide similar ping capabilities.
This implementation - with multiple threads launched in parallel - is
the more advanced one, so start reworking it to be able to use it in
the primary controller as well instead of _ping_backup_controller().

Add a boolean option to indicate whether this is running in the active
controller or the backup. This will control whether all other controllers
are pinged (needed by the primary) or only the higher priority controllers
(as done in the backups).

Bug 5256.

Bug 5651.

The correct syntax is .\" not .\ which was causing these to appear in the
man2html formatted version of the man page. As these options do not and will
not exist in 18.08, remove them rather than re-commenting them with the
correct syntax.

The correct syntax is .\" not .\ which caused these to appear in the man2doc
formatted version of the page by accident.

Update slurm.spec and slurm.spec-legacy as well.

And slurm.spec-legacy. Missed in commit ee281387.

Bug 4771.

Asterisk '*' was being used in 2.4, and replaced with colon ':' in 2.5.
But liense_list_to_string was missed, and was still using an asterisk
until now. Since we've internally used both up until 18.08, license parsing
code will need to respect both delimiters until two versions past 18.08.

Bug 5630.

Will be needed to distinguish between which backup controller is resuming.

Bug 5256.

No changes to RPC yet, identical to prior RPC version.

Bug 5256.

This should solve a clang/scan-build issue.

Bug 5256.

starting.

Bug 5565

Bug 5623

# Conflicts:
#	src/plugins/mpi/pmi2/setup.c

%n or %h in the spool dir.

Bug 5096

By default all devices are allowed and GRES, that are associated with a
device file, that are not requested are restricted.

Leaving the ability to read in the file as a contribution is under
review that extends the cgroup_allowed_devices_file.

Bug 4771.

Fail early when the layout requirements cannot be satisfied in
_task_layout_lllp_block().

Otherwise step layout calculations will fail, leading to a
"fatal: _task_layout_lllp_block infinite loop"

Bug 5415.

The conditional for handling --overcommit was not sufficient to prevent
other option combinations from using that code path, resulting in
unexpected resource allocation behavior. Correct that to check that
overcommit is enabled.

Bug 5345.