1. 13 Aug, 2018 2 commits
  2. 11 Aug, 2018 5 commits
  3. 10 Aug, 2018 1 commit
  4. 09 Aug, 2018 2 commits
  5. 07 Aug, 2018 3 commits
  6. 06 Aug, 2018 1 commit
    • Tim Wickberg's avatar
      Modify slurm_send_only_node_msg() to catch issues with socket. · 06582da8
      Tim Wickberg authored
      There are subtle issues involved in treating a TCP transmission
      as a unidirectional message delivery layer.
      
      The original code path looks like: connect(), write(), close().
      But Linux handles the write() and close() asynchronously behind the
      scenes, and does not block until that write() has been ACK'd by the
      remote end. So the write() and close() may succeed, even with data
      still in flight. A communication error - and message loss - would
      have been silently ignored, leading to unreliable message transmission.
      
      Worse yet, one side of the connection would believe it sent the message,
      while the receive side swears it never saw the packets. This leads to
      infrequent and yet seemingly impossible data loss, and a very tough
      bug to chase down.
      
      This teardown code tries to force the connection to shut down in an
      orderly manner, giving Slurm a chance to catch a connection problem
      and the upstream calling path an opportunity to retransmit.
      
      This teardown code is based on an approach described in Section 7.5
      of "UNIX Network Programming" Volume 1 (Third Edition), specifically
      the subsection regarding SO_LINGER. (And also covers why SO_LINGER is
      not sufficent to prevent this issue.)
      
      Bug 5164.
      06582da8
  7. 04 Aug, 2018 1 commit
  8. 31 Jul, 2018 1 commit
  9. 27 Jul, 2018 2 commits
  10. 19 Jul, 2018 4 commits
  11. 18 Jul, 2018 3 commits
  12. 17 Jul, 2018 3 commits
  13. 13 Jul, 2018 1 commit
  14. 12 Jul, 2018 3 commits
  15. 09 Jul, 2018 1 commit
  16. 06 Jul, 2018 1 commit
    • Marshall Garey's avatar
      Fix leaking freezer cgroups. · 7f9c4f73
      Marshall Garey authored
      Continuation of 923c9b37.
      
      There is a delay in the cgroup system when moving a PID from one cgroup
      to another. It is usually short, but if we don't wait for the PID to
      move before removing cgroup directories the PID previously belonged to,
      we could leak cgroups. This was previously fixed in the cpuset and
      devices subsystems. This uses the same logic to fix the freezer
      subsystem.
      
      Bug 5082.
      7f9c4f73
  17. 04 Jul, 2018 1 commit
  18. 03 Jul, 2018 1 commit
  19. 26 Jun, 2018 4 commits