reference commit 08425d9c

Update slurm.spec and slurm.spec-legacy as well

Also throws spurious errors of:
"slurmd: error: Domain socket directory /var/spool/slurmd: No such file or directory"
if you SlurmdSpoolDir is located elsewhere.

Bug 4289.

Add additional protection in slurmctld as well.

Bug 4826.

job_limits_check() uses the job desc to call _valid_pn_min_mem(). This
second function might adjust the following values (up to date):

cpus_per_task
pn_min_memory
min_cpus
max_cpus
pn_min_cpus

If the function returns success, these adjusted members need to be copied
back to the job_record. It turns out pn_min_cpus wasn't copied back,
thus the logs claimed to automatically increase pn_min_cpus but actually
the job record wasn't modified and the select plugin tried to allocate
wrong amount of resources.

Bug 4823.

Bug 4741.

No longer needed, and will cause errors on FreeBSD systems
build with WITHOUT_KERBEROS.

Bug 4805.

Relatively minor changes to burst_buffer/cray in preparation for
support of #DW create_persistent and #DW destroy_persistent operations

Bug 4783

"#DW destroy_persistent" directives available in Cray CLE6.0UP06. This
will be supported in Slurm version 18.08. Use "#BB" directives until then.

Bug 4302

Fix missing rename of functions.

Only a single io_timeout_thread should be created for each sls struct.

Creating multiple, while seemingly harmless in operation, can lead to
fatal() messages when srun shuts down by destroying mutex locks that
are in use by threads that srun doesn't expect to still have running.

Regression caused by a1185f04.

Bug 4596

Bug 4806.

This patch fixes the situation that makes features unrecognized where a node
features plugin is active and features are defined to nodes in slurm.conf.

It also preserves KNL node features when slurmctld daemons are reconfigured
including active and available modes.

Features not belonging to node features plugin are reset to what is in
slurm.conf when restarting or reconfiguring.

Bug 4734

_resv_overlap function was only checking the flags for the updated
reservation, but not for the rest of present ones. This implied
that the allowed overlap derived from these flags only applied
depending on the update order.

Bug 4806.

After commit b31fa177, we do not defer slurmd node registration if
HealthCheckProgram fails. So at slurmd startup, slurmd executes:

run_script_health_check();
_spawn_registration_engine();

And does not keeps spinning if NHC fails. Now if there are nodes
managed by the Power Save logic, when they are requested to be
POWER_UP because a job is allocated resources, then at slurmd startup
NHC is executed before node registers.

The problem comes when this NHC execution fails, if the NHC program
decides to update the node to DRAIN, since the job was already
allocated before this update, then the job will attempt to start
RUNNING but might fail since NHC detected there's something wrong.

So this change what it does is to detect DRAIN/FAIL node update
requests, then check if node is ALLOC/MIXED and POWER_[SAVE|UP] and
if so then force a requeue, so that the job doesn't start on a failed
node.

Bug 4689.

Can frequently throw scary-sounding messages on short-lived processes
that disappear while the stats are collected.

Bug 4759.

Bug 4793

When a pending job's state includes "UnavailableNodes" do not include
the nodes in FUTURE state.
bug 4612

Bug 4504

submission option.

Bug 4548

Bug 4548

Bug 4786

Continuation of 873871ed
Bug 4758

Bug 4758

Bug 4800

Bug 4793

Bug 4698.