Prevent possible divide by zero in select/cons_res if a node's board count
    is higher than it's socket count.
bug 3155

If a node's socket or core count are changed at registration time (e.g. a
    KNL node's NUMA mode is changed), change it's board count to match.
bug 3155

Cray: The slurmd can manipulate the socket/core/thread values reported based
    upon the configuration. The logic failed to consider select/cray with
    SelectTypeParameters=other_cons_res as equivalent to select/cons_res.
bug 3155

abs() should not be used on long long variables as it would
truncate if strictly confirming to C99. Use llabs() instead.

Fix to commit 2aefc66b.

These tests fail with a configuration of CR_ONE_TASK_PER_CORE.
  The tests are being disabled now for such a configuration, but
  could be modified to run in such an environment in the future.

Correct SchedulerParameters=bf_busy_nodes logic with respect to the job's
    minimum node count. Previous logic would not decremement counter in
    two locations and reject valid job request for not reaching minimum
    node count.

always just AccountingPolicy.

daf91a80

configure.

Add description of how to test for disabled Cray nodes and
avoid trying to use them in job allocations. Access to Cray
required to flesh out the code and test.

Accidentally added in commit f4887c74
bug 3124

See commit 37161057
Bug 3124.

Avoid printing sinfo output in test setup
Exit immediately on job submit failure (job_id == 0)
Preserve files if a test fails to help determine what happened
Initial commit in 37161057
bug 3124

Bug 3124.

Commit 59b118bf moved the call to
  _build_bitmaps() lower in the code, but that prevented node config_record
  data structures getting their node_bitmap fields set, causing the
  build_feature_list_eq() function to fail with a NULL node_bitmap field

node_features plugin - Add "mode" argument to node_features_p_node_xlate()
    function to fix some bugs updating a node's features using the node update
    RPC. Without this change it is impossible to clear the active features of
    a node or reset non-KNL node features.

If a node is initially determined to NOT be of type KNL, then don't
  ever look for it's MCDRAM or NUMA modes in cnselect output when
  dealing with job launch failures or unexpected node reboots.

node_features/knl_cray plugin: Substantially streamline and speed up logic
    to load current node state on reconfigure failure or unexpected node boot.
    Completely eliminate capmc calls and just use cnselect to load current
    node mode information.

node_features/knl_cray plugin: drain any node not reported by
    "capmc node_status" on startup or reconfig. Also re-tests
    on failed node restart for job.

node_features/knl_cray plugin: Remove any KNL MCDRAM or NUMA features from
    node's configuration if capmc does NOT report the node as being KNL.
    For example, we don't want a non-KNL node with features="quad,cache".

Found by clang.
Continuation of 76d62ae4

Add new knl.conf configuration parameter CapmcRetries
Modify capmc_suspend and capmc_resume to retry operations when
  Cray State Manager is down.
Add retry logic to node_features/knl_cray to handle Cray State
  manager being down.
bug 3100

from commit ee4a9776.

reset by list_count.  Also remove a nested if for cleaner code.

Logs go to both locations when running in non-daemonized mode.
Don't refer to this as "debug" mode, while useful for debugging
it's not directly related.

Bug 3146.

Otherwise they'll truncate when packed into the RPC and end up
as some bizarre value at the controller.

Bug 3098.

Set completed time for pending/running runaway jobs to the max of
(start, eligible, submit) times.

Bug 3075

Avoid using slurm_forward_data because it causes thread spawn that
introduces unwanted delays.

Bug 3102.

Fix indent and add brackets