Remove the TIME_FLOAT flag from the reservation to ensure _job_overlap()
does not add the current time on top of the start_time. The prior
approach was incorrect for non-TIME_FLOAT reservations and would
lead to valid reservations being rejected.

Bug 7458, 7908.

This reverts commit c55f6d65.

Bug 7458.

Signed-off-by: Michael Hinton <hinton@schedmd.com>

Bug 7169

Previously it was only after being idle. The problem was that if the
node was downed after a job ran on the node for more than SuspendTime
the node would be suspended quickly. Now it waits SuspendTime after
being idle or down (i.e. since no jobs on the node).

Bug 6774

Signed-off-by: Danny Auble <da@schedmd.com>

CUDA_VISIBLE_DEVICES was not being set to the correct GPU indexes when
cgroups were being used. These issues were exhibited with at least the
map_gpu and mask_gpu binding options.

The issue was that usable_gres is a bitmask of GRESs in the step's
cgroup, but bit_test() was looking at bit i, which is the index of the
global gres_list (not constrained by cgroups).

Bug 7509

In 19.05 JOB_MEM_SET flag was added along with a conditional check on
this flag that changed the pn_min_memory when validating job limits.
This caused that after an upgrade, PD jobs in earlier versions didn't
have this flag and the memory was incorrectly set when their limits were
checked before starting. The patch here addresses this issue adding this
flag to jobs from an older protocol version when loading the state
files.

Bug 8011

Previously, coordinators could delete specific associations, but could
not delete users. Allow coordinators to delete users if the users are
only part of accounts that the coordinator is over.

Bug 7413.

Bug 8035.

Bug 8031.

Bug 6633.

Bug 7103.

Bug 7875

Bug 7830

Bug 7936

Bug 7584

Bug 7584

Previously sched_nodes was set to the estimated nodes on the last
evaluated partition that was adding a reservation, instead of the
one offering the earliest estimated start time.

Natural continuation of fdae6a05

.

Bug 7344.

Signed-off-by: Dominik Bartkiewicz <bart@schedmd.com>

Bug 8014

Bug 7749

Bug 7995

Create generic function get_gres_count to get the node counts of any
GRES, not just GPUs.
Make get_gpu_count able to parse any combination of GRES names and
types.
Create get_gpu_count wrapper of get_gres_count for backwards
compatibility.
Expand the regex to not include newlines.
Rename variable gpu_count to gres_count.

Bug 7995

gres_node_config_load() requires gres_list to work properly after
fully merge slurm.conf with gres.conf logic added in 4d7df8b0.

Bug 7986

Bug 7490

If not enforcing QOS, it's possible to submit a job without a qos. If
submitting such a job to multiple partitions where at least one has a
qos, slurmctld would abort in a development build. A non-development
build didn't segfault only because _find_qos_part doesn't dereference
the NULL pointer. Prevent the abort.

Bug 7171

Bug 7171

Bug 7712

Now it will work with multiple GPU types. This currently affects tests
like a subset of the test39.* series and test1.62.

Bug 7884.

If there are less than 2 sockets per node, only the first part of the
test needs to be skipped. So the second half of the test was changed
to still run as long as 2+ GPUs are configured.

Also add headers to sub-tests while here.

Bug 7884.

Bug 7884.

Ensure gres_plugin_node_config_load() is called with a gres_list.

Bug 7884.

Otherwise we would be incorrectly reusing the previous to the
reconfiguration slurm.conf GRES value.

Continuation of previous commit.

Bug 7884.

Ensure that the stepd has slurm.conf GRES data. If the slurm.conf
input argument is NULL for gres_plugin_node_config_load(), then
gres_devices will end up being NULL, causing all GRES binding to not
work.

Bug 7884.

Previous logic would only call s_p_hashtbl_create() to create the hashtable
when the file acct_gather.conf could be successfully stat()'d. This lead to
a subsequent attempt to pack the non-created hashtable into a buffer which
triggered the abort.

This makes it so the hashtable is uncondtionally created no matter if the
file is missing.

Bug 7893.

gethostbyaddr() can potentially return a fully-qualified domain name,
which breaks backwards compatibility with the shortname AllocNodes
expected pre 19.05.

Bug 7653.

Fortunately the extra arguments were provided at the end, and thus ignored on
most common platforms.

Bug 7555.

This reverts commit e233ed11.