- 14 Apr, 2019 40 commits
-
-
Tim Wickberg authored
-
Tim Wickberg authored
Drop it from sbatch since it just printed an error if you tried to use it; getopt_long() will happily tell you that option isn't available itself.
-
Tim Wickberg authored
-
Tim Wickberg authored
Change slurm_opt_t field to 'exclude' to match command line. Node that the _valid_node_list() call is being moved into _opt_verify() where it probably should have been before. Since _valid_node_list() depends on several other settings, processing it when --exclude is processed may have resulted in inconsistent behavior if the order of the various arguments was changed around.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
Note that srun reset this only once, while salloc/sbatch reset each pass. Go with salloc/sbatch behavior - I do not think carrying the distribution over between components makes sense for most allocations at this time.
-
Tim Wickberg authored
Note this overlaps with the --exclusive option, but inverts the default behavior if no arguments are given.
-
Tim Wickberg authored
-
Tim Wickberg authored
Note that srun was previously using NO_VAL as unset which is technically an acceptable value; change it to -1 to match salloc/sbatch.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
Note changes needed for both the environment variable handling, as well as for PBS option parsing; have them call in to slurm_process_option().
-
Tim Wickberg authored
Simplify error handling, and explicitly test for NO_VAL as a return from time_str2mins().
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
There are two equivalent long-form options. Add a new LONG_OPT_CLUSTER to the enum to distinguish which form is used. (Needed for tracing at a later point in time.)
-
Tim Wickberg authored
Neither salloc/sbatch reset this. I believe reseting each pass, as is done by srun, is the correct behavior, otherwise each separate component will request additional licenses which is unintuitive.
-
Tim Wickberg authored
-
Tim Wickberg authored
For reset, salloc always reset this where sbatch/srun would not. Choosing to go with sbatch/srun's behavior.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
This should be avoided, but if there are multiple slurm_opt_t entries for a given val (e.g., -W in sbatch vs srun) check that we've found the correct entry. Non-single-character options do not have this issue since they should just use differing LONG_OPT values.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
A number of validation routines - especially within srun - care whether the variable was set through the environment, or by an explicit CLI option (or embedded in a job script). Provide an easy central test so this can be handled for all arguments.
-
Tim Wickberg authored
-