Clean up function definition blocks while here.

Was used for authd, but not for auth/munge or auth/none.

Don't alloc select_jobinfo and put it on the job_desc that is being
packed. If the job_desc is being packed simultaneously by mutliple
threads then problems can happen if the ptr is changing mid-flight.
So create and pack a local select_jobinfo.

Fix several memory leaks and file descriptor leaks in slurmstepd.
Prolems reported by Coverity.

Bug introduced in commit 0d4773a9

Fix 2 memory leaks
Fix 1 file descriptor leak
Fix 2 buffer overflow problems
All problems reported by Coverity

This bug, reported by Coverity, could result in memory corruption

Fix 3 possible memory leaks
Fix 1 possibly unterminated string
Prolems reported by Coverity

This isn't a real problem as the process does an exec right afterwards,
  but this change should make a Coverity error go away.

Two memory leaks
Invalid pointer use (function returning integer rather than pointer)
Out of bounds memory reference
Problems reported by Coverity

Reported by Coverity

Problem reported by Coverity, "description" never set, but tested
  and xfreed.

Fix 7 memory leaks in slurmdb archive functions in error handling logic.
  Problems reported by Coverity.

This commit should be part of b5f621d0
  when the man page was removed

Fix memory and file descriptor leaks in slurmd daemon's sbcast logic.

Also remove some redundant logic, a redundant variable, and speed
  things up a bit. Problem reported by Coverity.

Commit a7e57002 introduced a bug
  where a variable was freed before possible use in an error message.
  This is now fixed.

The part_ptr is sent into the function, there is no reason to look it up
again.  Coverity reported this.

_delete_part_record() should use list_flush rather than
relying on the "universal_key" to clear out the partition list.

Print debug messages instead of causing the config parser to fail.

No change in security posture, except that unauthorized users
could generate additional verbose() warnings.

Replace some of these getuid() calls used for security checks with
validate_slurm_user() instead.

Replace uid 0's in job_complete with correct slurmctld_conf.slurm_user_id

Fix for defining a buffer and possibly not having it NULL terminated
  after a copy. Problem reported by Coverity.

If hostlist token exceeded 1024 bytes then a buffer could overflow.
  This change also eliminates a buffer copy for better performances.
  Problem reported by Coverity.

This reverts commit 749420cf.

TravisCI uses 2-cpu nodes, so this causes the test to fail
as a suitable node cannot be found.

17.02 API has been changed so that node Port parameter is now packed and
unpacked on REQUEST_NODE_INFO RPC. 'scontrol write config' is now able to
write the Port on each of the node lines in the output file. Same way,
'scontrol show node' now displays the Port parameter too. 'sinfo' is able
to display the Port through -o "%j" or the -O "port" sinfo format string.
Default --long --Node sinfo output now includes the PORT too and sinfo is
also able to sort ascending/descending by Port through -S +/-j. sinfo man
page has been update accordingly. 'sview' also displays the Port when
displaying the full node information. Update of the Port parameter is not
supported through the clients.

Bug 3240

Move STEP_FLAG to slurmctld.h so it can be used in step_mgr.c.

Remove req_node_layout, which was only used with wiki/wiki2.
This leads to removal of _get_cpu_cnt() as well.

Remove SchedulerPort, only used for communication to Moab/Maui.
Remove slurm_get_sched_port() from API.
Remove schedport from slurm_ctl_conf struct.