This reverts commit 0581585c.

Do not change permissions on files the testsuite does not "own".

This is a duplicate of the previous 3547869b commit, which
was previously discarded by merge commit cf98dfc0.

Bug 4118.

On second thought, since we enable debug mode automatically this
won't be useful for what I plan to use it for, and since nothing
uses it let's just remove it entirely.

Doesn't really need to be directly in configure.ac, so move it.

Note that this has been subtly broken for quite a while:
- The correct variable to test is x_ac_debug, not ac_debug.
- The correct value when debugging is enabled is "yes", not "true".

Fix regression caused by commit bb8b4214.

Commit bb8b4214 introduced this in scontrol_hold():

-		job_msg.job_id_str = _next_job_id();
-		while (job_msg.job_id_str) {
+		while ((job_msg.job_id_str = _next_job_id())) {

But didn't take out _next_job_id() at the bottom of the while loop -
so _next_job_id() is called twice in a row, skipping every other job
in the list.

Bug 5902

rpaths, for RHEL based distros which use "check-rpaths" tool.

Bug 5780

Bug 5603

Bug 5603

a job is preempted.

Bug 5460

... due to a failure from DataWarp.

Bug 5800.

Update slurm.spec and slurm.spec-legacy as well.

Update slurm.spec and slurm.spec-legacy as well.

Caused by b1ff4342 when moving the slurmdbd agent internals.

Bug 5882.

Regression caused in 18.08.1; can happen under any circumstance that
leads to the job array elements being split before the backfill/sched
has had a chance to populate these.

Bug 5876.

# Conflicts:
#	src/common/slurmdbd_defs.c

up when the dbd was down.

This reverts commit c07784b4.

Bug 5875 and 5613

Change to true/false while here.

CID 188810.

The industry's settling on a term different than what we'd originally
gone with, so make a concession to the newer term and make it easier
to search for and discover.

Just return an xmalloc()'d string rather than handle all this
manual buffer length tracking. The only calling path into here
is trivially updated to work with this instead.

Note that gres_plugin_init() always returns 0 at present, so
take the opportunity to simplify that handling as well.