leaving the node owned.

Two jobs completing simultaneously leads to make_node_idle()
returning before it has a chance to decrement node_ptr->owner_job_cnt,
which can result in the node being "owned" by that user even
through no jobs are running on it.

Move the decrement block to the end at a fini label, and make sure
all return paths pass through it. While moving that add a guard
against node_ptr->owner_job_cnt underflowing.

Bug 3771.

WHOLE_NODE_USER.

If a job is considered on a partition with ExclusiveUser=YES
then it would be marked as if it was submitted with the
--exclusive flag, which would lead to delays launching it
on ExclusiveUser=NO partitions, and cause lower-than-expected
cluster usage.

As a side effect, the job_ptr->part_ptr->flags need to be
tested wherever WHOLE_NODE_USER is considered, instead of
just job_ptr->details->whole_node.

Bug 3771.

_setup_assoc_cond_limits was using the table 'prefix' passed by argument
in the where clause to select the where clause prefix.deleted=something.

It turns out that _setup_assoc_cond_limits is called by these functions:
as_mysql_modify_assocs
as_mysql_remove_assocs
as_mysql_get_assocs
as_mysql_acct_no_users

which set the prefix to 't2' before the call if a QOS is provided or if
WithSubAccounts is provided. The 't2' prefix is fine for other where
conditions in that case, but for choosing the deleted we need the t1
which is the table we're selecting the records off.

Bug 3835

There isn't much we can do about this, it will always be misspelled until
they fix it upstream.  We could correct it, but then every time we run
autogen.sh we would have to ignore the change which seems like more work
than I would want to keep doing.

Bug 3821

do the correct thing.

It turns out you can't += to *_SOURCES in a Makefile.am.  The corresponding
*_OBJECTS will not be made.  So I added a HAVE_LUA define and handled things
accordingly.

done in that commit, but only in the main scheduler instead of backfill.

'scontrol update reservationname=foo duration=unlimited' sets INFINITE
as the duration, which needs to be translated to a year as is done
elsewhere. Otherwise it'll convert to 49710 days, which is definitely
wrong.

Bug 3836.

Bug 3443.

MAX() will re-evaluate the higher value argument; if this is a function
is may be called twice over, leading to unintended side effects or a
crash.

Bug 3443.

Otherwise the recently newly added '#include <lua.h>' condition will
break the build on systems without any Lua installation.

Follow on to commit 7cc4d0d8. Bug 3681.

This also fixes the fed_mgr on the backup slurmctld to start backup
correctly if the backup takes control more than once.

Bug 3827

It will result in the job being held if it is requeued at a later time.

Bug 3751.

Previously, incorrect partitions and duplicated partition names
could be shown.

The array needs to be incremented by two, not one, as each
element is a start-end pair.

Bug 3793.

when configured with memory-leak-debug

Bug 2131

See bug 3681 comment 16

Follow on to commit 79ff60f4.

Bug 3681

Bug 3776

KNL modes if not KNL system.

Bug 3825

This reverts commit c2380520.

KNL modes if not KNL system.

Bug 3825

reconfigured while node boot in progress.

Bug 3679

bug 3822

Bug 3708

Bug 3815

not being able to deal with pn_min_memory being a uint64_t.  Scripts are
urged to change to these new variables avoid issue.  If not set the
variables will be 'nil'.

Bug 3681

In 17.11(or other future version) we should move a lot of this common
code into a new lib.  The reason I didn't put these common changes
into common/xlua.c was because then I would have to link common to
liblua which I really didn't want to do.

dependencies.

Bug 3708