Building off the prevoius commit, spank_option_getopt() is now valid in
more functions than before, so we document and enforce from where
spank_option_getopt() can safely be called and return ESPANK_NOT_AVAIL
if it is called from any invalid SPANK context.

Bug 7065.

When spank option callbacks are called, the options are added to a cache
in memory so that spank_option_getopt() can retrieve the options when
called. However, this was only happening when callbacks were called from
the local context, so we make sure that the options are added to the
cache when the callbacks are called from the remote context as well.

Bug 7065.

job_test_resv() - return ESLURM_RESERVATION_MAINT if all nodes
from the job partition are in a maintenance reservation.

Bug 7362.

If job requests feature(s) but the required nodes are in an advanced
reservation.

Bug 7362.

Previously the UnavailableNodes list could include nodes that don't
belong to the job partition.

Bug 7362.

The old proctrack/cray plugin was changed to proctrack/cray_aries.

Continuation of c6e6089f

Bug 6824.

Bug 7311

Update slurm.spec and slurm.spec-legacy as well.

Revert 86b0bd39 which removed slurm.FAILURE from job_submit/lua.

In a76a9486 we replaced SLURM_ERROR by SLURM_FAILURE. This commit
restores slurm.FAILURE as an synonym of SLURM_ERROR for job_submit/lua
scripts, which is now considered depreciated in 19.05.

Bug 7534.

task_id_bitmap can be free'd through:
	_update_job()
	-> acct_policy_remove_job_submit()
	-> acct_policy_handle_accrue_time()
	-> job_array_post_sched()

Bug 7537.

Bug 7219.

Continuation of fb1853fc

Bug 7315

Bug 7277

Fixes a couple of places missed in 50353e89.

Bug 7277

Bug 7498

Bug 7494.

Bug 7500

The tracking script rec was being left on the list.

Bug 7315

Lets track_script_thd_list's mutex be the authority for access to
track_script_rec_t objects.

Bug 7315

Bug 7315

Fixes possible deadlock on shutdown.

Bug 7315

This patch silences NodeFeatures messages that would otherwise print
if ANY debug flag is set, due to bad logic.

Bug 7156

Bug 7521.

Update test 39.18 infrastructure to enable tests.
Add better debugging capabilities.
Fix some broken tests due to the change.

Bug 7345

Base GRES type off of device name instead of brand name.
Make the device name lower case and replace spaces with underscores.
Truncate system-detected device names so they match GRES types in
slurm.conf (important for FastSchedule 0 and 1).

Bug 7345

Co-authored-by: Michael Hinton <hinton@schedmd.com>

Extra len_if_known can be used to avoid an additional strlen()
call (expensive on large strings) against str if the calling
location already knows this value.

Bug 6932.