Prevents correct error handling by rc being 0/1 instead of the original
return code.

Also fix slurm_send_only_controller_msg and slurm_send_only_node_msg
although these only result in bad printed values in the debug message.

Bug 2120

This bug was introduced by commit 21c52d2f
which fixed a different problem tracking resources associated with suspended
jobs. There are subtle differences between jobs that are suspended by a
user/administrator and jobs suspended by gang scheduling which resulted in
undercounting allocated CPUs when a job suspended by gang scheduling
was active at the same time of a slurmctld reconfiguration request.
See bugs 2353 (original bug related to commit 21c52d2f
and bug 2765

accounts) no default account is printed, previously NULL was printed.

This is just not printing it, but whole function should probably be
revisited as the rigmarole can probably be avoided as we always know what
the default is going to be if none is specified (first off the list).

The problem with that though is if the user has been added to a cluster
already and they have a default, but then added to a new cluster where
they don't have a default.  In this case you want to keep the first
clusters default, but set the default for the second cluster.

Bug 2725

Add missing unlock before return. Coverity 44888.

srun was modified to log
Warning: can't honor --ntasks-per-node set to 8 which doesn't match the requested tasks 23 with the number of requested nodes 3.  Ignoring --ntasks-per-node.
but this tests was parsing that warning, causing a test failure.
Modify the test's parsing logic.

This reverts commit cc242de3
That patch fixed bug 2745, but breaks tests 1.89 and 1.91 on
typical Xeon processors

This bug was introduced by commit 21c52d2f
which fixed a different problem tracking resources associated with suspended
jobs. There are subtle differences between jobs that are suspended by a
user/administrator and jobs suspended by gang scheduling which resulted in
undercounting allocated CPUs when a job suspended by gang scheduling
was active at the same time of a slurmctld reconfiguration request.
See bugs 2353 (original bug related to commit 21c52d2f
and bug 2765

accounts) no default account is printed, previously NULL was printed.

This is just not printing it, but whole function should probably be
revisited as the rigmarole can probably be avoided as we always know what
the default is going to be if none is specified (first off the list).

The problem with that though is if the user has been added to a cluster
already and they have a default, but then added to a new cluster where
they don't have a default.  In this case you want to keep the first
clusters default, but set the default for the second cluster.

Bug 2725

This also makes use of the -j (join) flag as a normal qsub does.

Fix for uninitialized variable in task binding logic, could leave tasks
    with fewer CPUs than intended.
bug 2766

Fix GRES task layout bug that could cause slurmctld to abort with
invalid memory reference.
bug 2766

Add missing unlock before return. Coverity 44888.

Coverity 44891.

sizeof(optarg) is incorrect, that's the size of the pointer
not the length of the character string that must be parsed.

Coverity 53128.

Coverity 44992.

bug 2760

Needs to unlock here, not re-lock the lock.