Coverity CID 174181

Otherwise use of libpmi will necessitate users also load libslurm,
  which has never been the case in past.
Bug introduced in commit f9687bbc

In all of these cases, the input account name is NULL, so there
  should never be a failure. In every case, the returned association
  pointer is checked anyway.
Coverity CID 44719, 44720, 44721

Coverity, CID 45150

bug 4061

Coverity CID 163084, 163085

Coverity CID 44762

If SLURM_BITSTR_LEN is set to some unreasonably large value it could
  result in the slurmctld allocating a huge memory buffer and consuming
  vast amounts of time.
Coverity CID 45264

CID 174162.

Coverity CID 45173

If one or more clusters in a federation are down, then print an
  appropriate warning and exit rather than cause the test to fail.
bug 4033

Mistake made in f9687bbc; strlcpy returns a count of chars copied
instead of a pointer to the string.

Otherwise the log will be spammed with "Buffer size limit exceeded".

Bug 3624.

Gets rid of one weird strlcpy call.

Ensure proper termination in places that were otherwise missing
it, and remove some awkward termination handling in other locations.

Starting from glibc-2.25 the macros major and minor are only available
from sys/sysmacros.h. This patch uses an autoconf macro to detect the
location and includes the header accordingly.

Bug 3982.

Unlike MPI, UCX requires each sender to have a unique tag, otherwise
messages will get mixed up.

Signed-off-by: Artem Polyakov <artpol84@gmail.com>

Fix direct connection table size to be equal to number of nodes
int the job instead of job step. This was triggering assert when,
for example, allocation was 16 nodes but srun was only using 2 of
them and not the first ones.

Signed-off-by: Artem Polyakov <artpol84@gmail.com>

middle of the other id_*.  I think it is ok to have the _id at the end for this
since we want the offset near it.

double ',' as we do with QOS in the TRES limits.  So I removed the logic to
check for it.

Bug 4019

Change to slurm_mutex_init
Coverity CID 171460

just unfreed memory, no real concern.

Replase "bool" with "int" as the return type of `pmixp_io_fd()`. This
was causing an interesting hidden bug affecting the performance.
Since this function was returning boolean value it was always
returning "1" instead of actual fd number. fd=1 is set to /dev/null
for slurmstepd, this is a char device that is always read/write ready
from the poll() perspective. So poll was continuously interrupting and
progress was fine, but CPU usage was ~100%.

Signed-off-by: Artem Polyakov <artpol84@gmail.com>

Signed-off-by: Artem Polyakov <artpol84@gmail.com>

(introduced in prev commit "Fix collective error path (timeout)"

Signed-off-by: Artem Polyakov <artpol84@gmail.com>

Signed-off-by: Artem Polyakov <artpol84@gmail.com>

UCP worker has to be re-armed after ucp_progress was called
on it. Original implementaition was done with wrong considerations
in mind.

Signed-off-by: Artem Polyakov <artpol84@gmail.com>