Bug 4933

Bug 4878

into contribs directory.

This should expose O_CLOEXEC on older glibc versions,
addressing build issues on CLE 5.2.

Bug 4843.

There are a few other unguarded uses of this.
Adding _GNU_SOURCE at the top of these files should expose this
macro instead.

This reverts commit 44775add.

MsgType=6500 wasn't being expanded:

"
slurm_persist_conn_open: Something happened with the
receiving/processing of the persistent connection init message to
XXX.XXX.XXX.XXX:6819: Failed to unpack MsgType=6500 message
"

Bug 4924

(slurmdbd was down when slurmctld was started).

Bug 4864

Bug 4864

Bug 4888

Set scontrol exit code to 1 if attempting to update a node to
DRAIN or DOWN without specifying a reason.

Bug 4920.

bug 4717

GCC-7 with -Wformat warns about

node_features_knl_cray.c:2869:33: warning: ‘%d’ directive output may be
truncated writing between 1 and 10 bytes into a region of size 8
[-Wformat-truncation=]
     snprintf(buf, sizeof(buf), "%d", i);
                                 ^~
node_features_knl_cray.c:2869:32: note: directive argument in the
range [0, 2147483647]
     snprintf(buf, sizeof(buf), "%d", i);
                                ^~~~
In file included from /usr/include/stdio.h:862:0,
                 from ../../../../slurm/slurm.h:68,
                 from node_features_knl_cray.c:66:
/usr/include/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’
output between 2 and 11 bytes into a destination of size 8
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Increasing the buffer to 12 for this.

Bug 4900.

Signed-off-by: Justin Lecher <jlec@gentoo.org>

when slurmctld was started) you could loose QOS usage information.

Bug 4865

To be used in a future commit for Bug 4865

6bc5dc30
6d4518fe

set to not be shown as runaway.

Bug 4847

Otherwise incorrect status could be registered in the database and completed
jobs be seen as pending, running, and so on.

Bug 4847

Looks like a regression accidentally introduced in d8770a66.

Bug 4769.

Bug 4549

Bug 4549

Bug 4549

Bug 4549

Bug 4549

Could happen if SuspendTimeout was shorter than ResumeTimeout.

Bug 4863

Continuation of 7d246784

bug 4849

Update slurm.spec and slurm.spec-legacy as well

Also throws spurious errors of:
"slurmd: error: Domain socket directory /var/spool/slurmd: No such file or directory"
if you SlurmdSpoolDir is located elsewhere.

Bug 4289.

Add additional protection in slurmctld as well.

Bug 4826.

job_limits_check() uses the job desc to call _valid_pn_min_mem(). This
second function might adjust the following values (up to date):

cpus_per_task
pn_min_memory
min_cpus
max_cpus
pn_min_cpus

If the function returns success, these adjusted members need to be copied
back to the job_record. It turns out pn_min_cpus wasn't copied back,
thus the logs claimed to automatically increase pn_min_cpus but actually
the job record wasn't modified and the select plugin tried to allocate
wrong amount of resources.

Bug 4823.

No longer needed, and will cause errors on FreeBSD systems
build with WITHOUT_KERBEROS.

Bug 4805.

Bug 4783

"#DW destroy_persistent" directives available in Cray CLE6.0UP06. This
will be supported in Slurm version 18.08. Use "#BB" directives until then.

Bug 4302

Only a single io_timeout_thread should be created for each sls struct.

Creating multiple, while seemingly harmless in operation, can lead to
fatal() messages when srun shuts down by destroying mutex locks that
are in use by threads that srun doesn't expect to still have running.

Regression caused by a1185f04.

Bug 4596