And out of the slurmctld code. Remove send_groups_in_cred handling
now that it's all handled inside slurm_cred.c.

There is a minor difference in functionality after this: the pw_gecos,
pw_dir, and pw_shell fields will be populated when they were not
previously. As the expensive part of the lookup is the underlying
getpwuid() syscall, this should not make a real difference.

Add a copy_gr_names() utility function to group_cache.c;
these lookups should be cached at some point to avoid the
performance hit from calling into getgrgid() constantly.

Lookup and send over the required struct passwd fields.

Match the other struct passwd fields added previously.

And handle pack/unpack for 19.05.

No functional change.

And always print a colon after the function name.

Without this change a heterogeneous job allocation could not run
a step on any single component of a hetjob, but only across multiple
hetjob components. Note that by default a step runs on only the
first hetjob component, so the default mode of operation running
steps on a hetjob was broken. This bug caused tests 38.7 and 38.11
to fail consistently. The bug was introduced in commit 2f162b7a

Commit 2987c5db (Convert "Admin Priority" to "Site Priority")
broke this test

Bug 6849.

Use retry_list_size() instead of list_count(retry_list) to avoid any asserts if list is NULL.

Bug 6849.

Bug 6849.

Bug 6849.

bug 6849.

Bug 6849.

Bug 6849.

Bug 6849.

Bug 6849.

Bug 6849.

Bug 6849.

Bug 6849.

Coverity CID 197727

Bug introduced in commit 7db859c0

Bug 6252

Bug 6440

Bug 6440

Reported by CLANG

This shouldn't happen in practice, but fixes CLANG error

The field requires an argument, but CLANG assumes none...

Error reported by CLANG