1. 11 Mar, 2016 3 commits
  2. 10 Mar, 2016 5 commits
    • Morris Jette's avatar
      cray job requeue bug · 536c8451
      Morris Jette authored
      Fix Cray NHC spawning on job requeue. Previous logic would leave nodes
      allocated to a requeued job as non-usable on job termination.
      
      Specifically, each job has a "cleaning/cleaned" flag. Once a job
      terminates, the cleaning flag is set, then after the job node health
      check completes, the value gets set to cleaned. If the job is requeued,
      on its second (or subsequent) termination, the select/cray plugin
      is called to launch the NHC. The plugin sees the "cleaned" flag
      already set, it then logs:
      error: select_p_job_fini: Cleaned flag already set for job 1283858, this should never happen
      and returns, never launching the NHC. Since the termination of the
      job NHC triggers releasing job resources (CPUs, memory, and GRES),
      those resources are never released for use by other jobs.
      
      Bug 2384
      536c8451
    • David Gloe's avatar
      Correctly parse nids in slurmconfgen_smw.py · e050806e
      David Gloe authored
      An error in slurmconfgen_smw.py caused it to parse the nic as the nid.
      On some systems those values differ, causing the generated slurm.conf file to
      be incorrect.
      
      Bug 2532.
      e050806e
    • Bill Brophy's avatar
      Fix route/topology plugin to prevent segfault in sbcast. · 0dfc924c
      Bill Brophy authored
      route_p_split_hostlist was not thread-safe, and would cause
      one of several segfaults depending on where in the initialization
      code each thread was.
      
      Bug 2495.
      0dfc924c
    • Tim Wickberg's avatar
      Fix displayed value for RoutePlugin. · db8491f1
      Tim Wickberg authored
      Was incorrectly displaying "(null)" even when loaded successfully.
      db8491f1
    • Morris Jette's avatar
      Add NEWS for commit 3bb2e602 · a0be0dc5
      Morris Jette authored
      a0be0dc5
  3. 09 Mar, 2016 2 commits
    • Morris Jette's avatar
      cray job requeue bug · fec5e03b
      Morris Jette authored
      Fix Cray NHC spawning on job requeue. Previous logic would leave nodes
      allocated to a requeued job as non-usable on job termination.
      
      Specifically, each job has a "cleaning/cleaned" flag. Once a job
      terminates, the cleaning flag is set, then after the job node health
      check completes, the value gets set to cleaned. If the job is requeued,
      on its second (or subsequent) termination, the select/cray plugin
      is called to launch the NHC. The plugin sees the "cleaned" flag
      already set, it then logs:
      error: select_p_job_fini: Cleaned flag already set for job 1283858, this should never happen
      and returns, never launching the NHC. Since the termination of the
      job NHC triggers releasing job resources (CPUs, memory, and GRES),
      those resources are never released for use by other jobs.
      
      Bug 2384
      fec5e03b
    • David Gloe's avatar
      Correctly parse nids in slurmconfgen_smw.py · 88ccc111
      David Gloe authored
      An error in slurmconfgen_smw.py caused it to parse the nic as the nid.
      On some systems those values differ, causing the generated slurm.conf file to
      be incorrect.
      
      Bug 2532.
      88ccc111
  4. 08 Mar, 2016 2 commits
  5. 07 Mar, 2016 1 commit
  6. 05 Mar, 2016 2 commits
  7. 04 Mar, 2016 3 commits
  8. 03 Mar, 2016 5 commits
    • Thomas Hamel's avatar
      Defer slurmd registration until NodeHealthCheck · 7fb0c981
      Thomas Hamel authored
      We want to introduce a new behavior in the way slurmd uses the
      HealthCheckProgram. The idea is to avoid a race condition between the
      first HealthCheckProgram run and the node accepting jobs. The slurmd
      daemon will initialize and then loop on HealthCheckProgram execution
      before registering with slurmctld. It will stay in this loop until
      the HealthCheckProgram returns successfully (the node is still DOWN).
      
      On our clusters we are using NHC as an HealthCheckProgram. NHC drains
      the node if it fails and remove the drain if it is successfull, this
      behavior fits well with our purpose. This behavior permits us to start
      slurmd at boot without setting up a complex boot sequence in the init
      system, slurmd just wait for the node to be ready before registering.
      
      The HealthCheckProgram is not run during slurmd startup if
      HealthCheckInteval is 0.
      7fb0c981
    • Danny Auble's avatar
      72f13426
    • Brian Christiansen's avatar
      5c43d754
    • Morris Jette's avatar
      Increase step GRES variable size · 7f0bdc84
      Morris Jette authored
      Step GRES value changed from type "int" to "int64_t" to support larger
      values. Previous logic could fail in step allocation values over 32-bits.
      Other GRES values are 64-bit.
      7f0bdc84
    • Danny Auble's avatar
      Force close on exec on first 256 file descriptors when launching a · f502f1e5
      Danny Auble authored
      slurmstepd to close potential open ones.
      
      It was pointed out the slurmd using acct_gather_energy/ipmi links to
      freeipmi which could possibly open /dev/ipmi0 without the close on exec
      flag set as root while launching a step leaving it open in the users app.
      
      What this does is sets the flag on the first 256 to mitigate the concern.
      
      Reported by Maksym Planeta.
      
      Bug 2506
      f502f1e5
  9. 02 Mar, 2016 4 commits
  10. 01 Mar, 2016 4 commits
    • Tim Wickberg's avatar
      Remove BEGIN_C_DECLS and END_C_DECLS macros. · 1434364d
      Tim Wickberg authored
      src/common/mapping.h was the one place outside of slurm/*h that used this,
      just remove it from there.
      
      Replace macro with #ifdef __cplusplus in slurm/*h in case anyone is linking
      C++ against libslurm.
      1434364d
    • Tim Wickberg's avatar
      Remove PARAMS macro from function definitions. · 6ad00816
      Tim Wickberg authored
      Macro hasn't been used consistently for three+ years, and is protecting against
      compilation by non-ANSI C compilers which has not been a concern for quite some
      time. Cleanup formatting of function declarations while here.
      
      No change to logic.
      6ad00816
    • Tim Wickberg's avatar
      Update NEWS as well. · a058ff4a
      Tim Wickberg authored
      a058ff4a
    • Morris Jette's avatar
      Defer suspend until launch completes · 52fe3de1
      Morris Jette authored
      Insure that a job is completely launched before trying to suspend it.
      Previous logic would start suspend logic early in the life of the
      slurmstepd process, after it's listening socket was open but before
      the tasks were launched. This defers the suspend logic until after
      all prologs and setup completes and the tasks are launched. This is
      important in the case of gang scheduling, in which newly launched
      jobs can be immediately suspended.
      bug 2494
      52fe3de1
  11. 29 Feb, 2016 1 commit
  12. 27 Feb, 2016 1 commit
  13. 26 Feb, 2016 5 commits
  14. 25 Feb, 2016 2 commits