The conditional for handling --overcommit was not sufficient to prevent
other option combinations from using that code path, resulting in
unexpected resource allocation behavior. Correct that to check that
overcommit is enabled.

Bug 5345.

Bug 5379.

This does change a network RPC after 18.08.0rc1, which is best to be
avoided. But other recent changes have already broken RPC compatibility
between what will be 18.08.0, so we might as well land this now.

Bug 5443.

and when reconfigured.

Bug 5602

The socket count argument was added to
gres_plugin_node_config_validate()
in commit 63b95516

And add into appropriate pack and unpack functions.

And set it in launch_prolog().

Previous logic would re-use altered node and core bitmaps,
which would tend to fail.
Change some data types for consistency

Cores on additional sockets may be used, but we want to insure some
cores on the identify sockets are included in the job allocation

In cases when you have a range first and then a single afterwards:

nid00[446-447],nid00392

It only worked correctly if it were reversed like so:

nid00392,nid00[446-447]

No functional change.

No function change here, identical to 17.11 protocol block.

Bug 5524

Basically count was never getting over 3 so none of the "end" code
was ever happening.

Make test suite aware of how GPUs are bound to sockets

Introduced in commit d382a477

Modify a gpu/socket binding test to recognize newly available
information from "scontrol show node" in commit 63b95516

# Conflicts:
#	src/slurmctld/fed_mgr.c

running.

Bug 5624

If GRES as associated with specific sockets, identify those sockets in the
    output of "scontrol show node". For example if all 4 GPUs on a node are
    all associated with socket zero, then "Gres=gpu:4(S:0)". If associated
    with sockets 0 and 1 then "Gres=gpu:4(S:0-1)". The information of which
    specific GPUs are associated with specific GPUs is not reported, but only
    available by parsing the gres.conf file.

for an allocation.

Bug 5293

Backport of 9a507584 in 18.08.

Fix possible reference of unset bitmap
Fix some logic problems related to non-socket bound GRES