- 14 Apr, 2019 40 commits
-
-
Tim Wickberg authored
Just check if sentinel value of NO_VAL is still set instead.
-
Tim Wickberg authored
Just check if sentinel value of NO_VAL is still set instead.
-
Tim Wickberg authored
While here, drop test on SLURM_STARTED_STEP envvar which is never set (was used with POE), and move this logic to _opt_verify().
-
Tim Wickberg authored
-
Tim Wickberg authored
Note that sbatch intentionally handles this in a different way - it injects the file contents into the job script, rather than sending it in burst_buffer in job_desc_msg_t. Replace three implementations of _read_file() with create_mmap_buf().
-
Tim Wickberg authored
-
Tim Wickberg authored
Use _unknown_ as the name here, since ? is obviously invalid.
-
Tim Wickberg authored
Drop egid from slurm_opt_t in favor of simpler handling of gid itself.
-
Tim Wickberg authored
Drop euid from slurm_opt_t in favor of simpler handling of uid itself.
-
Tim Wickberg authored
Note symbol hack to permit the help() functions to stay in place within the commands for now.
-
Tim Wickberg authored
Drop -u as an option for salloc/sbatch, since srun has it for --unbuffered. Note symbol hack to permit the usage() functions to stay in place within the commands for now.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
All salloc environment variables are now being handled through slurm_process_option().
-
Tim Wickberg authored
-
Tim Wickberg authored
Note one important difference: this delays processing of --hint until the verify pass, at which time --ntasks-per-core or --threads-per-core may have been evaluated. Previously, order of argument evaluation would change the result, despite a comment on each of these warning against such behavior. Also switch the order of SLURM_HINT and SBATCH_HINT - SBATCH_HINT will now override SLURM_HINT if both are set.
-
Tim Wickberg authored
-
Tim Wickberg authored
Handle the two separated envvars here as well.
-
Tim Wickberg authored
Drop option from srun, as it just prints an error.
-
Tim Wickberg authored
Set the default value to 0, and use that to indicate if set rather than tracking a separate kill_command_set variable in salloc_opt).
-
Tim Wickberg authored
Use slurm_option_set_by_env() in srun in one location, and remove network_set_env from srun_opt_t. Drop the direct SLURM_NETWORK envvar set in the srun option parsing - this was duplicated further below for Cray systems (the only ones using this variable) in _opt_args() and thus can be removed here.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
Get rid of job_name_set_cmd/job_name_set_env in srun_opt_t and use slurm_option_set_by_cli()/slurm_option_set_by_env() instead.
-
Tim Wickberg authored
Add this as an option to srun; there's no reason it can't use this as an alternative to --nodelist. Move the file parsing code to later in _opt_verify(). This should fix a potential source of problems if an #SBATCH directive points to a non-existent file which is being intentionally overridden on the command line.
-
Tim Wickberg authored
-
Tim Wickberg authored
Note that this intentionally discards the checks for a nice value < 0, which were previously limited to SlurmUser / root. However - an Admin is allowed by slurmctld to submit with a lower value, or they can alter the job after submission to change the nice value further. So get rid of that check here.
-
Tim Wickberg authored
Use -1 as the sentinel value, adjust srun to match salloc/sbatch.
-
Tim Wickberg authored
Note one difference after the change: an invalid optional argument to the flag will be rejected, rather than silently turning on --no-kill.
-
Tim Wickberg authored
Change cwd variable in slurm_opt_t to chdir to match argument.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
One minor change - an invalid environment variable will result in an exit(-1), rather than an error message.
-
Tim Wickberg authored
-
Tim Wickberg authored
-
Tim Wickberg authored
Reset on each pass for sbatch, but not touched in salloc/srun. Go with sbatch's behavior, which matches that of mail_user.
-