Revert 86b0bd39 which removed slurm.FAILURE from job_submit/lua.

In a76a9486 we replaced SLURM_ERROR by SLURM_FAILURE. This commit
restores slurm.FAILURE as an synonym of SLURM_ERROR for job_submit/lua
scripts, which is now considered depreciated in 19.05.

Bug 7534.

task_id_bitmap can be free'd through:
	_update_job()
	-> acct_policy_remove_job_submit()
	-> acct_policy_handle_accrue_time()
	-> job_array_post_sched()

Bug 7537.

Fixes a couple of places missed in 50353e89.

Bug 7277

Bug 7498

Bug 7500

This patch silences NodeFeatures messages that would otherwise print
if ANY debug flag is set, due to bad logic.

Bug 7156

Bug 7521.

Base GRES type off of device name instead of brand name.
Make the device name lower case and replace spaces with underscores.
Truncate system-detected device names so they match GRES types in
slurm.conf (important for FastSchedule 0 and 1).

Bug 7345

Co-authored-by: Michael Hinton <hinton@schedmd.com>

This apparently never was added even though it was documented.

Bug 7457

Bug 7457

When deleting associations and permission is denied, we weren't properly
handling the error in sacctmgr, so it would prompt to commit the changes
even though it already printed a permission denied error.

Bug 7413

Bug 7263

Partially reverts commit cb901366 and d8097da9.

Bug 7461

The early assertion fail prevented batch job launch or tasks launch on
non-Linux systems.

Bug 7471.

Bug 7429.

IP address if the reverse lookup fails.

Bug 7255.

Rewrite of commit f35bb686.

Bug 7340.

Wrapping the plugin interface with an #ifdef block as was previously
done still results in the plugin being generated, but without any
of the plugin symbols present. This will then cause errors when
running user commands similar to:
error: Couldn't load specified plugin name for switch/cray_aries: Plugin name/type/version symbol missing

Bug 7017.

Bug 7017.

Bug 7017.

Bug 7320

Bug 7320

This makes it so that the backup will reinint the fed_mgr and load fed
state when a backup takes over on subsequent takeovers.

Bug 7320

Fixes a compilation issue with the job_container/cncu plugin.

Bug 7398

Causes build failures on Debian ia64 platform, and per the glibc docs this
is an internal macro for them that should be getting set automatically
as long as we've defined _GNU_SOURCE before including our first glibc
header.

Fix the task/affinity plugin code to define _GNU_SOURCE first, and not
defer this to the affinity.h include (which may come after some glibc
headers have been included, leading to issues finding the CPU_SETSIZE
macro).

Bug 7152.

If plugin load fails, then slurmd will SEGFAULT later while attempting
to call one of the invalid function pointers. Instead, just abort during
loading.

Bug 7402.

If only allowing particular alloc nodes in a partition, deny any request coming from an alloc node of NULL.

Bug 7255

Account coordinators are allowed to add users to their accounts, but
cannot change the default account of a user. However, when a user is
added to an account and the user doesn't have an account yet, the
account is set as the user's default account, which counts as changing
the user's default account. This commit allows account coordinators to
add users who don't already have a default account elsewhere to the
accounts they are coordinators over.

Bug 7018.

Fixes a compilation issue with the job_container/cncu plugin.

Bug 7398

Would cause an unexpected reversion to 19.05.0 behavior if a QOS has
UsageFactor != 0 and any combination of flags set.

Bug 7215.

Use safe_unpackstr_xmalloc() instead of unpackstr_ptr to ensure all
strings are escaped correctly in SlurmDBD.

This requires the introduction of the _free_local_*() functions to free
the structure members, whereas they were previously just pointers into
the single managed buffer which was cleaned up elsewhere.

Remove the unsafe unpackstr_ptr macro definition as well while here.

CVE-2019-12838.

Bug 5213

Instead of rejecting a reservation update, create the reservation to
avoid return an error to slurmctld at which point it is too late to do
anything to fix the issue.

Bug 7155.

Wraps logic added in 43ef4f75 to apply UsageFactor at
submission/scheduling. Default is not to.

Bug 7215