Account coordinators are allowed to add users to their accounts, but
cannot change the default account of a user. However, when a user is
added to an account and the user doesn't have an account yet, the
account is set as the user's default account, which counts as changing
the user's default account. This commit allows account coordinators to
add users who don't already have a default account elsewhere to the
accounts they are coordinators over.

Bug 7018.

Fixes a compilation issue with the job_container/cncu plugin.

Bug 7398

Would cause an unexpected reversion to 19.05.0 behavior if a QOS has
UsageFactor != 0 and any combination of flags set.

Bug 7215.

Use safe_unpackstr_xmalloc() instead of unpackstr_ptr to ensure all
strings are escaped correctly in SlurmDBD.

This requires the introduction of the _free_local_*() functions to free
the structure members, whereas they were previously just pointers into
the single managed buffer which was cleaned up elsewhere.

Remove the unsafe unpackstr_ptr macro definition as well while here.

CVE-2019-12838.

Bug 5213

Instead of rejecting a reservation update, create the reservation to
avoid return an error to slurmctld at which point it is too late to do
anything to fix the issue.

Bug 7155.

Wraps logic added in 43ef4f75 to apply UsageFactor at
submission/scheduling. Default is not to.

Bug 7215

Needed to maintain compatibility with OpenMPI's mpirun/mpiexec
launch commands.

Bug 7191.

Slurm's xmalloc() internally always returns NULL on 0-sized allocations,
and this autoconf macro causes problems building with AddressSanitizer.

Bug 7180.

Add explicit support for BOOT_FAIL.
Rearrange db queries for "finished" states assuming -S and -E are
correctly set, as with the other states.
Add error() message to dbd if unsupported state is requested.
Add _supported_state() to the client and fatal() if unsupported state
is requested by the user of the client.

Bug 7110

Bug 7213

should override the real.

Test39.18 was failing by gathering real gpus erroneously.

Flags are stored in a smallint, which can only hold the first 16 bits
worth out of 32 bits of flags currently in use.

MySQL's overflow rules will treat any value > 0xffff as 0xffff, rather than
dropping the higher-order bits (flags), which means the stored value not
only loses the higher-order bits but corrupts the lower-order as well.

The 19.05 release extends the column to bigint (64 bit).

Bug 6969.

if OverTimeLimit is Unlimited.

Bug 6093

Copied from cons_res commit 8c919742

Bug 7249.

Cray plugin names were changed in 19.05, but the template was overlooked.

Bug 7294.

This was broken and then fixed all within the 19.05.1 time frame,
so it doesn't need a separate entry. My mistake on reviewing.

Bug 7146.

Front-end builds wouldn't compile otherwise. Oversight of 3f947d45.

Bug 7146.

The conditional for handling --overcommit was not sufficient to prevent
other option combinations from using that code path, resulting in
unexpected resource allocation behavior. Correct that to check that
overcommit is enabled.

Identical to cons_res commit 478e7641

Bug 5345.

Commit 2f571559 added internal calls to mysql_db_commit() in
_archive_purge_table(). Previous sacctmgr logic triggered the operation
and then asked for confirmation through commit_check(), making it
impossible to rollback even when the user discarded the changes.

Bug 7130.

Previous logic initialized a static variable once and forever. This
variable was used as a test to call or not log_job_resources and
dynamic changes through 'scontrol setdebugflags [+|-]SelectType' would
have no effect. New logic uses the standard select_debug_flags as
everywhere else and aligns with cons_tres logic.

Bug 7137.

Commit 2194edf3 was intended to change the default fairshare algorithm
to Fair Tree. There was an oversight with the conversion where Fair Tree
wouldn't be the default if PriorityFlags was commented out.

Bug 7154.

bug 7066

This is a continuation of commit edd09b55.

Bug 7071.

The init() function creates a separate thread that tries to index the
list of unindexed jobs (loaded from the state or newly finished) into
the elasticsearch server. This fix prevents this thread from trying to
do so until after slurm_jobcomp_set_location sets the log_url.

Bug 7153.

Also added TimeEligible as a field that can be requested.
Bug 7074

When fixing runaway jobs, submit time should always be set in the
database, so use that when rerolling usage. Avoids rerolling from 0.
Bug 7074

If bf_min_prio_reserve was not the last option listed, the setting would
not have been applied correctly, and an error message printed instead.

Bug 7242.

Bug 6221

Bug 7204

Bug 6221

Bug 7179.

Bug 6847
Bug 7190

For heterogeneous jobs, do not count the each component against the QOS or
association job limit multiple times.

bug 7190

Bug 6847

JobHeldUser state reason was properly set for user held jobs during the
course of job_allocate() execution until calling _select_nodes_parts()
which could override it under certain conditions (i.e. when accounting
policy limit is hit). The fix restores it back when appropriate.

Continuation of 8712a254.

Bug 7136.

Bug 7146.