It's old code, but a newly report.

With commit 3e00ede5, _pack_job_alloc_info_msg wasn't hitting the
xassert as expected.

burst_buffer logic modified to support sizes in both SI and EIC size units
    (e.g. M/MiB for powers of 1024, MB for powers of 1000).
bug 3922

This patch removes a window in which a message bound for the DBD
could be packed with the non-dbd packing.  This would result in a
packed msg_type, but nothing else.  When that message was given to
the DBD it would complain forever about an unpacking error.

Bug 3891 and 3939

list functions.

# Conflicts:
#	src/slurmd/slurmd/req.c
#	src/srun/libsrun/allocate.c

done.

Pretty much remove 10cc6f93

Bug 3919

Makes testing with multiple-slurmd much nicer.

slurmctld would previously hide partitions from super-users by default.
That was changed in commit f6a20584
The test was modified to support that change in behaviour

workflows through the slurmd.

Bug 3833

CID 45140 and 45141

CID 171492

CID 171497

CID 171451

CID 171480

CID 171477

CID 717487

Unhandled return code makes Coverity sad, use the macro for
consistency in these cases and to silence the warnings.

Coverity noticed we don't consistently use it and started flagging these.
Switch to the macro for consistency.

The re-use of error_code results in the function returning an error
  when it really functions properly. Added new variable to use.

Use part_is_visible instead, which does not modify the partitions
(and thus require the part write lock).

No longer require part write lock.

They now only need the part read lock, not the write lock.

Only needs part read lock, whereas part_filter_set/clear require
the part write lock which limits concurrency.

Convert one location in pack_all_part() while here.

Also remove long-hidden test program from parse_time.c.

Fix one location in sacctmgr that was altering the value to use a
heap-allocated value instead.

Previous implementation is not thread-safe.

Replace with direct references to the struct.