This reverts commit 450cd6c8.

Bug 5711

This will be re-reverted in 19.05 with other code changes we didn't feel
comfortable dealing with in 18.08.

Bug 5702

The backup slurmctld can end up without an agent thread if
read_slurm_conf() takes too long to complete. Forcing the agent_init()
here again ensures it is restarted if not currently running.

This was fixed upstream in c1a537db.

Bug 5633.

Functionality is still available if required, but has been deprecated
since 17.11, and has been removed on master before 19.05.

Un-document is now lest people start trying to use it.

support.

Bug 4871

is removed from the system.

Bug 5665

burst buffer.

Bug 5665

Bug 5359

Bug 5679

regression from combination of 037bb3cb and 5a6a26f6

node_registration_status_msg.

Bug 5672

Bug 5672

Coverity CID 164845

Bug 5529

Seconded by Moe.

LaunchParameters=send_gids.

Bug 5620

Bug 5659

This reverts commit 35285e40.

Bug 5659

Bug 5663

Spaces need to be built into each key definition, otherwise it'll
all run together.

Bug 5657.

Otherwise assoc_mgr_fill_in_user() will abort on a failed lock annotation.

Convert to designated initializer format while fixing this.

Bug 5653.

Move the trigger_backup_ctld_fail() call into ping_controllers(),
and use the ping_all boolean as a standin for whether we're the active
controller or not.

Bug 5256.

Bug 5651.

Will be needed to distinguish between which backup controller is resuming.

Bug 5256.

This should solve a clang/scan-build issue.

Bug 5256.

starting.

Bug 5565

Bug 5623

%n or %h in the spool dir.

Bug 5096

By default all devices are allowed and GRES, that are associated with a
device file, that are not requested are restricted.

Leaving the ability to read in the file as a contribution is under
review that extends the cgroup_allowed_devices_file.

Bug 4771.

Fail early when the layout requirements cannot be satisfied in
_task_layout_lllp_block().

Otherwise step layout calculations will fail, leading to a
"fatal: _task_layout_lllp_block infinite loop"

Bug 5415.

The conditional for handling --overcommit was not sufficient to prevent
other option combinations from using that code path, resulting in
unexpected resource allocation behavior. Correct that to check that
overcommit is enabled.

Bug 5345.

This does change a network RPC after 18.08.0rc1, which is best to be
avoided. But other recent changes have already broken RPC compatibility
between what will be 18.08.0, so we might as well land this now.

Bug 5443.

Bug 5524

Basically count was never getting over 3 so none of the "end" code
was ever happening.

running.

Bug 5624

for an allocation.

Bug 5293

Backport of 9a507584 in 18.08.

return a start and end time set to the window end time, so elapsed
time is 0.

Bug 5372

Bug 5619

Tim approved

Bug 5618

Development continues on the master branch for 19.05, but the
snapshot here should not be used and is thus being removed.

Remove the commented-out documentation as well.

Bug 5608

Tim approved