This is a continuation to 7da439b4

Bug 7445

Only do so once the task actually finishes. Otherwise, a requeued task
could set an incorrect max_exit_code even if completed with exit code 0
after re-running again, leading to problems with i.e. other jobs with an
afterok type of dependency on such array relying on the incorrectly set
max_exit_code.

Bug 7552.

In case of features like cpu&fastio&[knl|westmere] additional bit_or
resulted in returning something like (cpu&fastio)|knl|westmere, which
is obviously wrong. XOR/XAND features are handled properly in
_get_req_features.

Bug 7378

Handle situation where a slurmctld tries to communicate with slurmdbd more than once at the same time.

What can happen here is the slurmdbd/slurmctld connection gets hung up
somehow.  If the slurmctld is restarted a new connection is made along
side the old connection.  When the old connection gets unwedged the old
connection will clear out the registration of the slurmctld making it so
no updates are sent to that slurmctld.

What this does is checks for old connections when a registration message
comes in.  If we find one we print error set the rem_port = 0 and
remove it from the list.  This makes it so when it gets unwedged we just
close the socket instead of remove the registration.

Bug 5213

Bug 7360.

in track scripts code.

Bug 7360


Signed-off-by: Alejandro Sanchez <alex@schedmd.com>

The implementation of priority_p_job_end in priority/multifactor
expects the job state to be set to complete or completing in order to
properly remove some job usage from the assoc and qos. This must be
simulated by the pack job run check code, or the check-time usage is not
removed.

Bug 7284

It wasn't properly set under certain conditions.

Bug 7276

Bug 7410.

Consider jobs in COMPLETING state as being available immediatley for
a job will-run evaluation. This assumes the completion will happen
very soon after the test is run.

bug 6769

All of the select plugins were performing a duplicate resource free
for jobs in completing state when performing a will-run test for
new jobs. This would frequently result in underflow messages.

Bug 6769

Building off the prevoius commit, spank_option_getopt() is now valid in
more functions than before, so we document and enforce from where
spank_option_getopt() can safely be called and return ESPANK_NOT_AVAIL
if it is called from any invalid SPANK context.

Bug 7065.

When spank option callbacks are called, the options are added to a cache
in memory so that spank_option_getopt() can retrieve the options when
called. However, this was only happening when callbacks were called from
the local context, so we make sure that the options are added to the
cache when the callbacks are called from the remote context as well.

Bug 7065.

job_test_resv() - return ESLURM_RESERVATION_MAINT if all nodes
from the job partition are in a maintenance reservation.

Bug 7362.

If job requests feature(s) but the required nodes are in an advanced
reservation.

Bug 7362.

Previously the UnavailableNodes list could include nodes that don't
belong to the job partition.

Bug 7362.

The old proctrack/cray plugin was changed to proctrack/cray_aries.

Continuation of c6e6089f

Bug 6824.

Revert 86b0bd39 which removed slurm.FAILURE from job_submit/lua.

In a76a9486 we replaced SLURM_ERROR by SLURM_FAILURE. This commit
restores slurm.FAILURE as an synonym of SLURM_ERROR for job_submit/lua
scripts, which is now considered depreciated in 19.05.

Bug 7534.

task_id_bitmap can be free'd through:
	_update_job()
	-> acct_policy_remove_job_submit()
	-> acct_policy_handle_accrue_time()
	-> job_array_post_sched()

Bug 7537.

Fixes a couple of places missed in 50353e89.

Bug 7277

Bug 7498

Bug 7500

This patch silences NodeFeatures messages that would otherwise print
if ANY debug flag is set, due to bad logic.

Bug 7156

Bug 7521.

Base GRES type off of device name instead of brand name.
Make the device name lower case and replace spaces with underscores.
Truncate system-detected device names so they match GRES types in
slurm.conf (important for FastSchedule 0 and 1).

Bug 7345

Co-authored-by: Michael Hinton <hinton@schedmd.com>

This apparently never was added even though it was documented.

Bug 7457

Bug 7457

When deleting associations and permission is denied, we weren't properly
handling the error in sacctmgr, so it would prompt to commit the changes
even though it already printed a permission denied error.

Bug 7413

Bug 7263

Partially reverts commit cb901366 and d8097da9.

Bug 7461

The early assertion fail prevented batch job launch or tasks launch on
non-Linux systems.

Bug 7471.

Bug 7429.

IP address if the reverse lookup fails.

Bug 7255.

Rewrite of commit f35bb686.

Bug 7340.

Wrapping the plugin interface with an #ifdef block as was previously
done still results in the plugin being generated, but without any
of the plugin symbols present. This will then cause errors when
running user commands similar to:
error: Couldn't load specified plugin name for switch/cray_aries: Plugin name/type/version symbol missing

Bug 7017.

Bug 7017.

Bug 7017.